Skip to content

style: apply biome 2.x safe autofixes across the repo#518

Merged
coderdan merged 2 commits into
mainfrom
chore/biome-format-cleanup
Jun 19, 2026
Merged

style: apply biome 2.x safe autofixes across the repo#518
coderdan merged 2 commits into
mainfrom
chore/biome-format-cleanup

Conversation

@coderdan

Copy link
Copy Markdown
Contributor

Follow-up to #517 (the config migration). Stacked on chore/biome-2-config — review/merge that first; this retargets to main once it lands.

What

With biome.json parsing again under biome 2.x, ran biome check --write to clear the backlog of auto-fixable findings that were invisible while the config was broken. Safe fixes only--unsafe was not used.

  • 310 files fixed; errors 345 → 8
  • Changes are formatting reflow + safe lint fixes (e.g. import sorting). Representative diff is whitespace/layout (e.g. it.each([...]) reflow) with identical behavior.
  • No bare side-effect imports (import 'x') were reordered (verified) — so no import-ordering side-effect risk.

Blast radius

296 files (278 .ts, 14 .json, 4 .mjs):

area files area files
prisma-next 87 wizard 17
stack 61 drizzle 8
cli 47 scripts 6
examples 29 bench 6
protect 28 (other) 7

Verification

This is mechanical, but verified as far as the local env allows (no DB/credentials here):

  • CLI (47 files reformatted) — pnpm test312 passed
  • scripts (6 .mjs) — self-tests 20 passed, plus lint:runners and lint:workflow-cache (the CI lint scripts) pass
  • wizard / schema / protect-dynamodb — unit tests pass
  • stack / protect / drizzle / prisma-next — their failing suites are pre-existing DB-integration tests (Missing env.DATABASE_URL, searchable-json-pg) that fail identically on the base branch; not affected by this change
  • Only safe fixes applied, so behavior is preserved by construction

Out of scope (follow-up)

After this, biome still reports 8 errors + 394 warnings + 81 infos that are not safe-autofixable — these need manual review (and/or a reviewed biome check --write --unsafe pass). Left for a separate change so this PR stays purely mechanical.

Notes

  • biome is not run in CI, so none of this gates the pipeline today; it restores a clean baseline for local code:fix.
  • Expect a conflict with feat(cli): guard against missing native binaries #516 in packages/cli/src/bin/stash.ts (that PR rewrites the file). Whichever merges second should rebase; the cleanup here is formatting-only.

@coderdan coderdan requested a review from a team as a code owner June 17, 2026 03:26
@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8a365b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 300 files, which is 150 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1af3ea6-64bd-43e5-a390-8c67e20946e1

📥 Commits

Reviewing files that changed from the base of the PR and between 8ab3368 and 8a365b2.

📒 Files selected for processing (300)
  • e2e/tests/package-managers.e2e.test.ts
  • e2e/tests/prisma-example-readme.e2e.test.ts
  • e2e/tests/supply-chain.e2e.test.ts
  • e2e/wasm/roundtrip.test.ts
  • examples/basic/index.ts
  • examples/basic/src/encryption/index.ts
  • examples/basic/src/lib/supabase/encrypted.ts
  • examples/basic/src/lib/supabase/server.ts
  • examples/basic/src/queries/contacts.ts
  • examples/prisma/migrations/app/20260513T1735_initial/end-contract.d.ts
  • examples/prisma/migrations/app/20260513T1735_initial/end-contract.json
  • examples/prisma/migrations/app/20260513T1735_initial/migration.json
  • examples/prisma/migrations/app/20260513T1735_initial/migration.ts
  • examples/prisma/migrations/app/20260513T1735_initial/ops.json
  • examples/prisma/migrations/cipherstash/20260601T0000_install_eql_bundle/contract.json
  • examples/prisma/migrations/cipherstash/20260601T0000_install_eql_bundle/migration.json
  • examples/prisma/migrations/cipherstash/20260601T0000_install_eql_bundle/ops.json
  • examples/prisma/migrations/cipherstash/contract.d.ts
  • examples/prisma/migrations/cipherstash/contract.json
  • examples/prisma/migrations/cipherstash/refs/head.json
  • examples/prisma/prisma-next.config.ts
  • examples/prisma/src/prisma/contract.d.ts
  • examples/prisma/src/prisma/contract.json
  • examples/prisma/test/e2e/bigint.e2e.test.ts
  • examples/prisma/test/e2e/bool.e2e.test.ts
  • examples/prisma/test/e2e/date.e2e.test.ts
  • examples/prisma/test/e2e/global-setup.ts
  • examples/prisma/test/e2e/harness.ts
  • examples/prisma/test/e2e/json.e2e.test.ts
  • examples/prisma/test/e2e/mixed.e2e.test.ts
  • examples/prisma/test/e2e/num.e2e.test.ts
  • examples/prisma/test/e2e/str-range.e2e.test.ts
  • examples/prisma/test/e2e/vitest.config.ts
  • packages/bench/__tests__/db-only.test.ts
  • packages/bench/__tests__/drizzle/operators.explain.test.ts
  • packages/bench/__tests__/harness.test.ts
  • packages/bench/src/cli/setup.ts
  • packages/bench/src/drizzle/setup.ts
  • packages/bench/src/harness/seed.ts
  • packages/cli/src/__tests__/database-url.test.ts
  • packages/cli/src/__tests__/native.test.ts
  • packages/cli/src/__tests__/supabase-migration.test.ts
  • packages/cli/src/commands/auth/login.ts
  • packages/cli/src/commands/db/activate.ts
  • packages/cli/src/commands/db/install.ts
  • packages/cli/src/commands/db/push.ts
  • packages/cli/src/commands/db/rewrite-migrations.ts
  • packages/cli/src/commands/db/status.ts
  • packages/cli/src/commands/db/supabase-migration.ts
  • packages/cli/src/commands/db/test-connection.ts
  • packages/cli/src/commands/db/upgrade.ts
  • packages/cli/src/commands/db/validate.ts
  • packages/cli/src/commands/doctor/index.ts
  • packages/cli/src/commands/encrypt/backfill.ts
  • packages/cli/src/commands/encrypt/context.ts
  • packages/cli/src/commands/encrypt/cutover.ts
  • packages/cli/src/commands/encrypt/drop.ts
  • packages/cli/src/commands/encrypt/lib/db-readers.ts
  • packages/cli/src/commands/encrypt/plan.ts
  • packages/cli/src/commands/encrypt/status.ts
  • packages/cli/src/commands/impl/__tests__/how-to-proceed.test.ts
  • packages/cli/src/commands/impl/index.ts
  • packages/cli/src/commands/impl/steps/handoff-wizard.ts
  • packages/cli/src/commands/impl/steps/how-to-proceed.ts
  • packages/cli/src/commands/index.ts
  • packages/cli/src/commands/init/__tests__/utils.test.ts
  • packages/cli/src/commands/init/detect-agents.ts
  • packages/cli/src/commands/init/lib/__tests__/install-skills.test.ts
  • packages/cli/src/commands/init/lib/__tests__/parse-plan.test.ts
  • packages/cli/src/commands/init/lib/__tests__/rollout-state.test.ts
  • packages/cli/src/commands/init/lib/__tests__/setup-prompt.test.ts
  • packages/cli/src/commands/init/lib/build-agents-md.ts
  • packages/cli/src/commands/init/lib/handoff-helpers.ts
  • packages/cli/src/commands/init/lib/rollout-state.ts
  • packages/cli/src/commands/init/lib/setup-prompt.ts
  • packages/cli/src/commands/init/lib/write-context.ts
  • packages/cli/src/commands/init/providers/__tests__/base.test.ts
  • packages/cli/src/commands/init/providers/__tests__/supabase.test.ts
  • packages/cli/src/commands/init/steps/authenticate.ts
  • packages/cli/src/commands/plan/index.ts
  • packages/cli/src/commands/status/__tests__/status.test.ts
  • packages/cli/src/commands/status/index.ts
  • packages/cli/src/commands/status/render.ts
  • packages/cli/src/config/database-url.ts
  • packages/cli/src/index.ts
  • packages/cli/src/installer/index.ts
  • packages/cli/src/native.ts
  • packages/cli/tests/e2e/runner-aware-help.e2e.test.ts
  • packages/cli/tsconfig.json
  • packages/drizzle/__tests__/drizzle.test.ts
  • packages/drizzle/__tests__/operators-jsonb.test.ts
  • packages/drizzle/__tests__/operators.test.ts
  • packages/drizzle/src/bin/generate-eql-migration.ts
  • packages/drizzle/src/bin/runner.ts
  • packages/drizzle/src/pg/index.ts
  • packages/drizzle/src/pg/operators.ts
  • packages/drizzle/src/pg/schema-extraction.ts
  • packages/migrate/src/backfill.ts
  • packages/migrate/src/index.ts
  • packages/prisma-next/migrations/20260601T0000_install_eql_bundle/end-contract.d.ts
  • packages/prisma-next/migrations/20260601T0000_install_eql_bundle/migration.json
  • packages/prisma-next/migrations/20260601T0000_install_eql_bundle/migration.ts
  • packages/prisma-next/migrations/20260601T0000_install_eql_bundle/ops.json
  • packages/prisma-next/src/contract-authoring.ts
  • packages/prisma-next/src/contract.d.ts
  • packages/prisma-next/src/contract.json
  • packages/prisma-next/src/execution/abort.ts
  • packages/prisma-next/src/execution/cell-codec-factory.ts
  • packages/prisma-next/src/execution/codec-runtime.ts
  • packages/prisma-next/src/execution/decrypt-all.ts
  • packages/prisma-next/src/execution/envelope-base.ts
  • packages/prisma-next/src/execution/envelope-bigint.ts
  • packages/prisma-next/src/execution/envelope-boolean.ts
  • packages/prisma-next/src/execution/envelope-date.ts
  • packages/prisma-next/src/execution/envelope-double.ts
  • packages/prisma-next/src/execution/envelope-json.ts
  • packages/prisma-next/src/execution/envelope-string.ts
  • packages/prisma-next/src/execution/helpers.ts
  • packages/prisma-next/src/execution/middleware-registry.ts
  • packages/prisma-next/src/execution/operators.ts
  • packages/prisma-next/src/execution/parameterized.ts
  • packages/prisma-next/src/execution/routing.ts
  • packages/prisma-next/src/execution/sdk.ts
  • packages/prisma-next/src/exports/codec-types.ts
  • packages/prisma-next/src/exports/column-types.ts
  • packages/prisma-next/src/exports/contract-space-typing.ts
  • packages/prisma-next/src/exports/control.ts
  • packages/prisma-next/src/exports/middleware.ts
  • packages/prisma-next/src/exports/migration.ts
  • packages/prisma-next/src/exports/operation-types.ts
  • packages/prisma-next/src/exports/pack.ts
  • packages/prisma-next/src/exports/runtime.ts
  • packages/prisma-next/src/extension-metadata/codec-metadata.ts
  • packages/prisma-next/src/extension-metadata/constants.ts
  • packages/prisma-next/src/extension-metadata/descriptor-meta.ts
  • packages/prisma-next/src/middleware/bulk-encrypt.ts
  • packages/prisma-next/src/migration/call-classes.ts
  • packages/prisma-next/src/migration/cipherstash-codec.ts
  • packages/prisma-next/src/migration/codec-hooks-factory.ts
  • packages/prisma-next/src/migration/eql-bundle.ts
  • packages/prisma-next/src/migration/eql-install.generated.ts
  • packages/prisma-next/src/stack/derive-schemas.ts
  • packages/prisma-next/src/stack/from-stack.ts
  • packages/prisma-next/src/stack/sdk-adapter.ts
  • packages/prisma-next/src/types/codec-types.ts
  • packages/prisma-next/src/types/operation-types.ts
  • packages/prisma-next/test/abort.test.ts
  • packages/prisma-next/test/authoring.test.ts
  • packages/prisma-next/test/bulk-encrypt-middleware.test.ts
  • packages/prisma-next/test/bundling-isolation.test.ts
  • packages/prisma-next/test/call-classes.test.ts
  • packages/prisma-next/test/call-classes.types.test-d.ts
  • packages/prisma-next/test/cipherstash-codec-numeric.test.ts
  • packages/prisma-next/test/cipherstash-codec-other-codecs.test.ts
  • packages/prisma-next/test/cipherstash-codec-string.test.ts
  • packages/prisma-next/test/cipherstash-codec.test.ts
  • packages/prisma-next/test/codec-runtime.test.ts
  • packages/prisma-next/test/column-types.test.ts
  • packages/prisma-next/test/decrypt-all.test.ts
  • packages/prisma-next/test/derive-schemas.test.ts
  • packages/prisma-next/test/descriptor.test.ts
  • packages/prisma-next/test/envelope-bigint.test.ts
  • packages/prisma-next/test/envelope-boolean.test.ts
  • packages/prisma-next/test/envelope-date.test.ts
  • packages/prisma-next/test/envelope-double.test.ts
  • packages/prisma-next/test/envelope-json.test.ts
  • packages/prisma-next/test/envelope-string.test.ts
  • packages/prisma-next/test/envelope.types.test-d.ts
  • packages/prisma-next/test/equality-trait-removal.test.ts
  • packages/prisma-next/test/from-stack-divergence.test.ts
  • packages/prisma-next/test/helpers.test.ts
  • packages/prisma-next/test/helpers.types.test-d.ts
  • packages/prisma-next/test/operation-types.types.test-d.ts
  • packages/prisma-next/test/operator-lowering-equality.test.ts
  • packages/prisma-next/test/operator-lowering-order-range.test.ts
  • packages/prisma-next/test/operator-lowering-text-search.test.ts
  • packages/prisma-next/test/operator-lowering.helpers.ts
  • packages/prisma-next/test/operator-lowering.test.ts
  • packages/prisma-next/test/psl-interpretation-numeric.test.ts
  • packages/prisma-next/test/psl-interpretation-other-types.test.ts
  • packages/prisma-next/test/psl-interpretation.test.ts
  • packages/prisma-next/test/routing.test.ts
  • packages/prisma-next/test/runtime-descriptor.test.ts
  • packages/prisma-next/test/sdk-adapter.test.ts
  • packages/prisma-next/test/sdk.types.test-d.ts
  • packages/prisma-next/vitest.config.ts
  • packages/protect-dynamodb/__tests__/error-codes.test.ts
  • packages/protect-dynamodb/src/operations/search-terms.ts
  • packages/protect/__tests__/deprecated/search-terms.test.ts
  • packages/protect/__tests__/encrypt-query-searchable-json.test.ts
  • packages/protect/__tests__/encrypt-query-stevec.test.ts
  • packages/protect/__tests__/error-codes.test.ts
  • packages/protect/__tests__/keysets.test.ts
  • packages/protect/__tests__/number-protect.test.ts
  • packages/protect/__tests__/supabase.test.ts
  • packages/protect/src/bin/runner.ts
  • packages/protect/src/bin/stash.ts
  • packages/protect/src/client.ts
  • packages/protect/src/ffi/index.ts
  • packages/protect/src/ffi/model-helpers.ts
  • packages/protect/src/ffi/operations/batch-encrypt-query.ts
  • packages/protect/src/ffi/operations/bulk-decrypt-models.ts
  • packages/protect/src/ffi/operations/bulk-decrypt.ts
  • packages/protect/src/ffi/operations/bulk-encrypt-models.ts
  • packages/protect/src/ffi/operations/bulk-encrypt.ts
  • packages/protect/src/ffi/operations/decrypt-model.ts
  • packages/protect/src/ffi/operations/decrypt.ts
  • packages/protect/src/ffi/operations/deprecated/search-terms.ts
  • packages/protect/src/ffi/operations/encrypt-model.ts
  • packages/protect/src/ffi/operations/encrypt-query.ts
  • packages/protect/src/ffi/operations/encrypt.ts
  • packages/protect/src/helpers/index.ts
  • packages/protect/src/identify/index.ts
  • packages/protect/src/index.ts
  • packages/protect/src/stash/index.ts
  • packages/protect/src/types.ts
  • packages/stack/__tests__/audit.test.ts
  • packages/stack/__tests__/backward-compat.test.ts
  • packages/stack/__tests__/basic-protect.test.ts
  • packages/stack/__tests__/bulk-protect.test.ts
  • packages/stack/__tests__/cjs-require.test.ts
  • packages/stack/__tests__/drizzle-operators-jsonb.test.ts
  • packages/stack/__tests__/encrypt-query-searchable-json.test.ts
  • packages/stack/__tests__/encrypt-query-stevec.test.ts
  • packages/stack/__tests__/encrypt-query.test.ts
  • packages/stack/__tests__/error-codes.test.ts
  • packages/stack/__tests__/error-helpers.test.ts
  • packages/stack/__tests__/fixtures/index.ts
  • packages/stack/__tests__/helpers.test.ts
  • packages/stack/__tests__/infer-index-type.test.ts
  • packages/stack/__tests__/json-protect.test.ts
  • packages/stack/__tests__/jsonb-helpers.test.ts
  • packages/stack/__tests__/keysets.test.ts
  • packages/stack/__tests__/lock-context.test.ts
  • packages/stack/__tests__/nested-models.test.ts
  • packages/stack/__tests__/null-guards.test.ts
  • packages/stack/__tests__/number-protect.test.ts
  • packages/stack/__tests__/protect-ops.test.ts
  • packages/stack/__tests__/schema-builders.test.ts
  • packages/stack/__tests__/searchable-json-pg.test.ts
  • packages/stack/__tests__/supabase.test.ts
  • packages/stack/__tests__/types.test-d.ts
  • packages/stack/src/client.ts
  • packages/stack/src/drizzle/index.ts
  • packages/stack/src/drizzle/operators.ts
  • packages/stack/src/drizzle/schema-extraction.ts
  • packages/stack/src/dynamodb/helpers.ts
  • packages/stack/src/dynamodb/index.ts
  • packages/stack/src/dynamodb/operations/bulk-decrypt-models.ts
  • packages/stack/src/dynamodb/operations/bulk-encrypt-models.ts
  • packages/stack/src/dynamodb/operations/decrypt-model.ts
  • packages/stack/src/dynamodb/operations/encrypt-model.ts
  • packages/stack/src/dynamodb/types.ts
  • packages/stack/src/encryption/helpers/index.ts
  • packages/stack/src/encryption/helpers/infer-index-type.ts
  • packages/stack/src/encryption/helpers/model-helpers.ts
  • packages/stack/src/encryption/helpers/validation.ts
  • packages/stack/src/encryption/index.ts
  • packages/stack/src/encryption/operations/base-operation.ts
  • packages/stack/src/encryption/operations/batch-encrypt-query.ts
  • packages/stack/src/encryption/operations/bulk-decrypt-models.ts
  • packages/stack/src/encryption/operations/bulk-decrypt.ts
  • packages/stack/src/encryption/operations/bulk-encrypt-models.ts
  • packages/stack/src/encryption/operations/bulk-encrypt.ts
  • packages/stack/src/encryption/operations/decrypt-model.ts
  • packages/stack/src/encryption/operations/decrypt.ts
  • packages/stack/src/encryption/operations/encrypt-model.ts
  • packages/stack/src/encryption/operations/encrypt-query.ts
  • packages/stack/src/encryption/operations/encrypt.ts
  • packages/stack/src/identity/index.ts
  • packages/stack/src/index.ts
  • packages/stack/src/schema/index.ts
  • packages/stack/src/supabase/index.ts
  • packages/stack/src/supabase/query-builder.ts
  • packages/stack/src/supabase/types.ts
  • packages/stack/src/types-public.ts
  • packages/stack/src/types.ts
  • packages/stack/src/wasm-inline.ts
  • packages/wizard/src/__tests__/agent-sdk.test.ts
  • packages/wizard/src/__tests__/commandments.test.ts
  • packages/wizard/src/__tests__/detect.test.ts
  • packages/wizard/src/__tests__/format.test.ts
  • packages/wizard/src/__tests__/gateway-messages.test.ts
  • packages/wizard/src/__tests__/health-checks.test.ts
  • packages/wizard/src/__tests__/hooks.test.ts
  • packages/wizard/src/__tests__/interface.test.ts
  • packages/wizard/src/__tests__/prerequisites.test.ts
  • packages/wizard/src/__tests__/wizard-tools.test.ts
  • packages/wizard/src/health-checks/index.ts
  • packages/wizard/src/lib/gather.ts
  • packages/wizard/src/lib/rewrite-migrations.ts
  • packages/wizard/src/lib/wire-call-sites.ts
  • packages/wizard/src/run.ts
  • packages/wizard/src/tools/wizard-tools.ts
  • packages/wizard/tsconfig.json
  • scripts/__tests__/fixtures/allowed-fallback.ts
  • scripts/__tests__/fixtures/identifier.ts
  • scripts/__tests__/lint-no-hardcoded-runners.test.mjs
  • scripts/__tests__/lint-no-workflow-caching.test.mjs
  • scripts/lint-no-hardcoded-runners.mjs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/biome-format-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from chore/biome-2-config to main June 17, 2026 04:44
@coderdan coderdan force-pushed the chore/biome-format-cleanup branch from da3be8a to b793578 Compare June 17, 2026 04:46
@coderdan coderdan requested a review from Copilot June 19, 2026 12:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

coderdan added 2 commits June 19, 2026 23:39
Now that biome.json parses under biome 2.x (#517), run `biome check --write`
to clear the backlog of auto-fixable findings that were invisible while the
config was unparseable. Safe fixes only — formatting reflow plus safe lint
fixes (import sorting, etc.). The 351 unsafe fixes and the remaining
non-autofixable lint findings are intentionally left for manual follow-up.

Mechanical change; no behavior change. Verified: CLI suite (312 tests) and
script self-tests (20) pass; reformatted packages with credential-free unit
tests pass; the remaining monorepo test failures are pre-existing
DB-integration tests (Missing DATABASE_URL) that fail identically on the
base branch.
… pass

Formats 5 source files that landed on main after this branch was first
written (wasm-inline, cli native/doctor, wasm e2e test). Pure biome 2.x
safe-fix output, except: biome mangles the inline comment on
WasmClientConfig's intersection type into nonsense prose, so that note is
relocated into the object body where biome leaves it stable (idempotent).
@coderdan coderdan force-pushed the chore/biome-format-cleanup branch from b793578 to 8a365b2 Compare June 19, 2026 13:50
@coderdan

Copy link
Copy Markdown
Contributor Author

Rebase + behavior-change review

Rebased onto latest main (no conflicts — the anticipated stash.ts clash with #516 didn't materialize; git's 3-way merge handled it since the cleanup is formatting-only) and reviewed thoroughly to confirm no behavior changed. Verified four ways, strongest first:

1. Byte-for-byte reproduction (decisive)

Ran the repo's pinned biome check --write (safe only, no --unsafe) on a clean worktree of current main and compared file-by-file against the branch. All 296 touched files are byte-identical to biome's fresh output — so the diff contains only biome's mechanical safe-fix output, with no hand edits able to slip in.

2. Type-import safety under verbatimModuleSyntax

Most packages set verbatimModuleSyntax: true, under which a wrong importimport type classification is a compile error. pnpm build across all 10 packages passed, including every DTS build — so the type-import changes (mostly merging import type {A} + import {b}import { type A, b }) are correct and behavior-preserving.

3. Side-effect import ordering

Confirmed no bare/side-effect imports (import 'x') were reordered — the only way import sorting could change runtime behavior. Matches the PR description's claim.

4. Test parity

CLI suite (47 files reformatted, the largest chunk): 319 passed, green.

The substantive-looking hunks are all line-wrap reflow and standard safe lint fixes (useConst, useTemplate, import organizing) — behavior-preserving by construction.

Top-up

A fresh biome run on current main fixed 301 files vs this PR's original 296 — the 5 extra are files that landed on main after the branch was first written (e2e/wasm/roundtrip.test.ts, packages/cli/src/native.ts + its test, packages/cli/src/commands/doctor/index.ts, packages/stack/src/wasm-inline.ts). I formatted those too, so a fresh biome check --write now produces zero further changes to tracked source — a fully clean baseline.

One non-mechanical edit: biome mangles the inline comment on WasmClientConfig's intersection type into garbled prose, and re-mangles it in every position around the & (...) (a biome limitation with comments between & and a parenthesized union). Rather than commit nonsense, I relocated that note into the object body where biome leaves it stable (verified idempotent). It's comment-only — no behavior impact.

Post-top-up verification

  • Full-tree biome check: clean (only the expected files differ from base)
  • turbo build (stack + cli): green, incl. DTS/typecheck under verbatimModuleSyntax
  • CLI suite: 319 passed

Branch is rebased and mergeable pending review approval.

@coderdan coderdan merged commit df9c8e3 into main Jun 19, 2026
13 checks passed
@coderdan coderdan deleted the chore/biome-format-cleanup branch June 19, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants